[PATCH] D12089: Implement __aeabi_c{d,f}{cmpeq,cmple,rcmple}.

Stephen Hines via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 18 17:20:03 PDT 2015


srhines added inline comments.

================
Comment at: lib/builtins/arm/aeabi_cdcmpeq_helper.c:19
@@ +18,3 @@
+int __aeabi_cdcmpeq_helper(int32_t a, int32_t b) {
+    return isnan_d(a) || isnan_d(b);
+}
----------------
jmgao wrote:
> rengolin wrote:
> > srhines wrote:
> > > Couldn't this be using __builtin_isnan instead of redefining it?
> > or even calling it directly from the asm function?
> Doesn't __builtin_isnan do overloading via magic and/or generic macros? Is there an actual symbol I can jump to?
It looks like you resolved the issue here (by calling through with the appropriate C type). Was this just a stale reply?


http://reviews.llvm.org/D12089





More information about the llvm-commits mailing list