[PATCH] D12111: x32. Fixes a bug in x32 exception handling.

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 18 16:44:59 PDT 2015


rnk accepted this revision.
rnk added a reviewer: rnk.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm


================
Comment at: test/CodeGen/X86/x32-landingpad.ll:18
@@ +17,3 @@
+  %0 = landingpad { i8*, i32 } cleanup
+; The Excception Pointer is %eax; the Exception Selector, %edx.
+; CHECK: movl %eax, {{.*}}
----------------
s/Excception/Exception/

================
Comment at: test/CodeGen/X86/x32-landingpad.ll:19
@@ +18,3 @@
+; The Excception Pointer is %eax; the Exception Selector, %edx.
+; CHECK: movl %eax, {{.*}}
+; CHECK: movl %edx, {{.*}}
----------------
You probably want to tighten up the CHECK with something like this:
  ; CHECK: LBB{{.*}} : # %lpad
  ; CHECK-DAG: movl %eax, {{.*}}
  ; CHECK-DAG: movl %edx, {{.*}}
  ; CHECK: callq bar


http://reviews.llvm.org/D12111





More information about the llvm-commits mailing list