[PATCH] D12121: Support: Clean up TSan annotations.

Peter Collingbourne via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 18 15:18:25 PDT 2015


pcc added inline comments.

================
Comment at: lib/Support/ManagedStatic.cpp:17
@@ -16,2 +16,3 @@
 #include "llvm/Support/Atomic.h"
+#include "llvm/Support/Compiler.h"
 #include "llvm/Support/Mutex.h"
----------------
eugenis wrote:
> why do you need this?
This file uses tsan annotations, so it needs this header. I imagine we got away with this until now because `ManagedStatic.h` included `Valgrind.h`.

================
Comment at: lib/Support/Statistic.cpp:27
@@ -26,2 +26,3 @@
 #include "llvm/Support/CommandLine.h"
+#include "llvm/Support/Compiler.h"
 #include "llvm/Support/Debug.h"
----------------
eugenis wrote:
> why do you need this? Part of the following change?
Likewise


http://reviews.llvm.org/D12121





More information about the llvm-commits mailing list