[PATCH] D11648: InstCombinePHI: Partial simplification of identity operations

[David Majnemer via llvm-commits]

majnemer added inline comments.

================
Comment at: lib/Transforms/InstCombine/InstCombinePHI.cpp:883-885
@@ +882,5 @@
+                                      IC.getTargetLibraryInfo())) {
+      NewInst->eraseFromParent();
+      return nullptr;
+    }
+
----------------
Please do not create instructions that you end up destroying once you realize that the transform isn't appropriate.  Instead, perform an upfront check.


Repository:
  rL LLVM

http://reviews.llvm.org/D11648