[PATCH] llvm-build: Adopt generation of LLVM_LIBS_TO_EXPORT

Dan Liew via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 18 13:07:27 PDT 2015


On 18 August 2015 at 08:12, Brad King <brad.king at kitware.com> wrote:
> On 08/17/2015 02:48 PM, Dan Liew wrote:
>> alternative version of patch 0003 which filters based on the
>> "installed" property.
>> It also emits the libraries that were skipped as comments into
>> ``Makefile.llvmbuild``.
>
> Thanks.  That works but still leaves some of the gtest filtering
> in cmake/modules/Makefile.  The write_cmake_exports_fragment
> step in llvm-build needs the same filter.  Then this hunk:
>
>  -      ) | grep -v gtest > $@
>  +      ) > $@
>
> from my original 0003 in cmake/modules/Makefile can be restored.
> The "grep -v LLVMBUILD_LIB_DEPS_gtest" filter should be the
> only mention of "gtest" in that Makefile.

Oops. Sorry. The fixed patch is attached.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003v3-Filter-libraries-that-are-not-installed-out-of-CMake.patch
Type: application/octet-stream
Size: 4104 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150818/255fa4f4/attachment.obj>


More information about the llvm-commits mailing list