[PATCH] D12106: [CMake] Refactoring add_compiler_rt functions for darwin runtimes.

Filipe Cabecinhas via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 18 11:10:53 PDT 2015


filcab added inline comments.

================
Comment at: compiler-rt/trunk/cmake/Modules/AddCompilerRT.cmake:109
@@ +108,3 @@
+        LIBRARY DESTINATION ${COMPILER_RT_LIBRARY_INSTALL_DIR})
+    elseif(LIB_STATIC)
+      add_library(${name} STATIC ${LIB_SOURCES})
----------------
If I pass `SHARED` *and* `STATIC`, I only get `SHARED`? Maybe an error would be useful, here (straight to error, since it's a developer problem (bad CMake call)).


Repository:
  rL LLVM

http://reviews.llvm.org/D12106





More information about the llvm-commits mailing list