[compiler-rt] r245263 - [sanitizer] Move definition of stable-runtime to common lit config.

Evgenii Stepanov via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 18 11:06:31 PDT 2015


On Tue, Aug 18, 2015 at 7:51 AM, Renato Golin <renato.golin at linaro.org> wrote:
> On 18 August 2015 at 02:06, Evgeniy Stepanov via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
>> Author: eugenis
>> Date: Mon Aug 17 20:06:51 2015
>> New Revision: 245263
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=245263&view=rev
>> Log:
>> [sanitizer] Move definition of stable-runtime to common lit config.
>>
>> There are tests in sanitizer_common that are unconditionally disabled
>> because they REQUIRE: stable-runtime which is never defined.
>
> Hi Evgeniy,
>
> I have reverted this change in r245292 along my own attempt to fix
> (r245287), since UBsan didn't catch the memo about stable-runtime, and
> was running the tests.
>
> I'm not sure why UBsan would rely on ASAN's stable-runtime and not on
> the global one, but that needs investigating before we can turn this
> on again.
>
> I agree it's a good change, just need to be done right. :)

Thanks, I'll look into it.


More information about the llvm-commits mailing list