[PATCH] D12084: [llvm-readobj] Add support for MachO DataInCodeDataCommand

[Rafael Ávila de Espíndola via llvm-commits]

rafael accepted this revision.
rafael added a comment.
This revision is now accepted and ready to land.

LGTM with nits since this will be getting tests as it replaces macho-dump.


================
Comment at: MachODumper.cpp:614
@@ +613,3 @@
+      W.printNumber("Data size", LLC.datasize);
+      ListScope D(W, "Data Regions");
+      unsigned NumRegions = LLC.datasize / sizeof(MachO::data_in_code_entry);
----------------
Regions or entries?

================
Comment at: MachODumper.cpp:619
@@ +618,3 @@
+                                                              LLC.dataoff, i);
+        DictScope Group(W, "DICE");
+        W.printNumber("Index", i);
----------------
Entry (or Region) is probably better than DICE.

================
Comment at: llvm-readobj.cpp:186
@@ +185,3 @@
+  cl::opt<bool>
+  MachODataInCode("macho-dice",
+                  cl::desc("Display MachO Data in Code command"));
----------------
Name the option macho-data-in-code maybe?



http://reviews.llvm.org/D12084