[PATCH] D11876: [Support] Always wait for GraphViz before opening the viewer

David Wiberg via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 17 12:52:24 PDT 2015


dwiberg added a subscriber: dwiberg.
dwiberg added a comment.

This looks good to me. I do however not have commit rights which means I can't give an official approval. I did encounter the issue this patch fixes when testing the changes in http://reviews.llvm.org/D11877.

A suggestion for a follow-up patch is to rename "ExecGraphViewer" since it's used both for generation and viewing of the graph which can be a bit confusing.


Repository:
  rL LLVM

http://reviews.llvm.org/D11876





More information about the llvm-commits mailing list