[PATCH] D10555: [X86] Replace avx2.pbroadcast intrinsics with native IR.

Sanjay Patel via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 17 10:53:41 PDT 2015


spatel added a comment.

In http://reviews.llvm.org/D10555#225105, @RKSimon wrote:

> Along with an update of avx2intrin.h to call __builtin_shufflevector directly (and suitable tests to ensure that debug code doesn't change in the future) I'd say that this should be a win, but if people are still hesitant we should at least push forward with support in instcombiner now instead of putting it off.


My vote is for an instcombine solution just for the sake of implementation consistency...of course, I don't think there's been any consensus that the instcombine solution is the right way forward.

Possibly related: I just hit the same problem as https://llvm.org/bugs/show_bug.cgi?id=24125 , so anything we can do to make that fix easier should be considered. The current crashing is really unpleasant.


http://reviews.llvm.org/D10555





More information about the llvm-commits mailing list