[PATCH] D12074: [WinEHPrepare] Replace unreasonable funclet terminators with unreachable

Joseph Tremoulet via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 17 08:43:14 PDT 2015


JosephTremoulet accepted this revision.
This revision is now accepted and ready to land.

================
Comment at: test/CodeGen/WinEH/wineh-demotion.ll:325
@@ +324,3 @@
+  call void @f()
+  cleanupret token %cp0 unwind label %cleanup2
+}
----------------
JosephTremoulet wrote:
> Is this input valid?  I don't think the def of %cp0 dominates the use here (path where first invoke returns normally, second invoke raises exception reaches here via cleanup2 without passing through the def at cleanup1).
Oh, I misread it; that 2nd invoke is unreachable and cleanup2 is only reachable from this cleanupret, which is dominated by cleanup1.  Sorry for the noise, objection rescinded.


http://reviews.llvm.org/D12074





More information about the llvm-commits mailing list