[PATCH] D12074: [WinEHPrepare] Replace unreasonable funclet terminators with unreachable

[Joseph Tremoulet via llvm-commits]

JosephTremoulet accepted this revision.
JosephTremoulet added a comment.
This revision is now accepted and ready to land.

LGTM with one nit.


================
Comment at: lib/CodeGen/WinEHPrepare.cpp:3242-3243
@@ -3217,1 +3241,4 @@
                                       Function &F) {
+  if (isa<CatchPadInst>(V) || isa<CleanupPadInst>(V))
+    return;
+
----------------
I think this is subtle enough to merit a comment (along the lines of "We can't demote a token but it's safe to skip these since cloning will remove mismatched uses").


http://reviews.llvm.org/D12074