[PATCH] D12072: [FIX] Restrict the AST build with the assumed context

Johannes Doerfert via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 17 02:27:47 PDT 2015


On 08/17, Tobias Grosser wrote:
> grosser accepted this revision.
> grosser added a comment.
> This revision is now accepted and ready to land.
> 
> This new fix looks good to me.
> 
> Please update the commit message to explain the issue and the resolution. I would appreciate if you give some more details about the context, such that other people looking at your commit learn about the necessary context of our scalar code generation.
I already did but arcanist doesn't update the commit messages when I
update the diff :(

> Regarding the other fix, I did not yet look into this, but would probably leave it for now
> as it is. If you want to get it in, we need to check if restricting the ast_build does not
> have a high cost in case of a complicated assumed context.
I think it might be worth it but I don't have numbers yet. I might try
to generate some tonight.

-- 

Johannes Doerfert
Researcher / PhD Student

Compiler Design Lab (Prof. Hack)
Saarland University, Computer Science
Building E1.3, Room 4.31

Tel. +49 (0)681 302-57521 : doerfert at cs.uni-saarland.de
Fax. +49 (0)681 302-3065  : http://www.cdl.uni-saarland.de/people/doerfert
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 213 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150817/0890d919/attachment.sig>


More information about the llvm-commits mailing list