[PATCH] D12042: Remove redundant TargetFrameLowering::getFrameIndexOffset virtual function.

[James Y Knight via llvm-commits]

jyknight added inline comments.

================
Comment at: lib/Target/X86/X86RegisterInfo.cpp:495-496
@@ -494,1 +494,4 @@
+
+  // FIXME: should/can this function use the FrameReg output of
+  // getFrameIndexReference instead of re-creating the logic here?
   if (hasBasePointer(MF))
----------------
rnk wrote:
> Currently, no. This code handles fixed stack objects (FI < 0) and AfterFPPop, while the frame lowering code does not. Eventually, maybe. :)
Added that information in a comment on X86 getFrameIndexReference.


Repository:
  rL LLVM

http://reviews.llvm.org/D12042