[compiler-rt] r245073 - [windows] Fix or XFAIL remaining portable test failures and enable them

David Wiberg via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 14 12:19:54 PDT 2015


> Modified: compiler-rt/trunk/test/asan/lit.cfg
> URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/asan/lit.cfg?rev=245073&r1=245072&r2=245073&view=diff
> ==============================================================================
> --- compiler-rt/trunk/test/asan/lit.cfg (original)
> +++ compiler-rt/trunk/test/asan/lit.cfg Fri Aug 14 12:39:48 2015
> @@ -190,5 +190,5 @@ if config.host_os == 'Darwin':
>
>  # AddressSanitizer tests are currently supported on Linux, Darwin and
>  # FreeBSD only.
> -if config.host_os not in ['Linux', 'Darwin', 'FreeBSD']:
> +if config.host_os not in ['Linux', 'Darwin', 'FreeBSD', 'Windows']:
>    config.unsupported = True
>

Hi Reid,

While skimming the patch I noticed that the comment here is out of
date due to the change. Perhaps it would be better to change it to
something more generic which avoids listing the different operating
systems to avoid the problem in the future.

Best regards
David


More information about the llvm-commits mailing list