[PATCH] D12019: [windows] Fix or XFAIL remaining portable test failures and enable them

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 14 10:21:22 PDT 2015

rnk marked 2 inline comments as done.

Comment at: test/asan/TestCases/coverage-disabled.cc:8
@@ -7,3 +7,3 @@
 // RUN: mkdir -p %T/coverage-disabled/normal
-// RUN: %env_asan_opts=coverage_direct=0:coverage_dir=%T/coverage-disabled/normal:verbosity=1 %run %t
+// RUN: %env_asan_opts=coverage_direct=0:coverage_dir='"%T/coverage-disabled/normal"':verbosity=1 %run %t
 // RUN: not %sancov print %T/coverage-disabled/normal/*.sancov 2>&1
samsonov wrote:
> Do you really need both kinds of quotes?
Yes, the double quotes need to go through into the environment variable on Windows because filepaths expanded from %T and %S contain colons after the drive letter. Since colon is the ASAN_OPTIONS separator, it must be quoted. Using single quotes is just my preferred way of escaping the double quotes. I could use backslashes.

Basically, this isn't a shell portability issue, it's an ASAN_OPTIONS parsing portability issue.

Comment at: test/asan/TestCases/interception_failure_test.cc:8
@@ -7,2 +7,3 @@
 // RUN: %clangxx_asan -O3 %s -o %t && %run %t 2>&1 | FileCheck %s
-// XFAIL: freebsd
+// On Windows, defining strtoll results in linker errors.
+// XFAIL: freebsd,win32
samsonov wrote:
> If the interception machinery works differently on Windows, just move this to Posix/ ?
I don't think it's impossible to intercept strtoll on Windows, so this test should pass eventually.


More information about the llvm-commits mailing list