[PATCH] D11814: Define a subtarget feature to force stack realignment

hfinkel@anl.gov via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 13 17:01:18 PDT 2015


hfinkel added a subscriber: hfinkel.
hfinkel requested changes to this revision.
hfinkel added a reviewer: hfinkel.
hfinkel added a comment.
This revision now requires changes to proceed.

I don't think this is the right design for this feature: Forcing essentially all targets to add the same subtarget feature and associated logic is not good.

Instead, please add this to include/llvm/Target/TargetOptions.h, and add default handling in lib/Target/TargetMachine.cpp (command-line options, function attributes, etc.).


http://reviews.llvm.org/D11814





More information about the llvm-commits mailing list