[PATCH] D11764: [DAGCombiner] Attempt to mask vectors before zero extension instead of after.

[Chandler Carruth via llvm-commits]

chandlerc added a comment.

Very nice. LGTM when you have the SystemZ stuff sorted out.


================
Comment at: test/CodeGen/X86/vec_cast2.ll:100
@@ -100,3 +99,3 @@
 ; CHECK-WIDE-NEXT:    vpinsrb $0, %eax, %xmm0, %xmm1
-; CHECK-WIDE-NEXT:    vmovshdup %xmm0, %xmm2    ## xmm2 = xmm0[1,1,3,3]
+; CHECK-WIDE-NEXT:    vmovshdup {{.*#+}} xmm2 = xmm0[1,1,3,3]
 ; CHECK-WIDE-NEXT:    vcvttss2si %xmm2, %eax
----------------
This looks like just a boring re-generation of the test change. Land it separately (and first)?


Repository:
  rL LLVM

http://reviews.llvm.org/D11764