[PATCH] D11996: [ARM] Fix MachO CPU Subtype inference in llvm::createARMAsmBackend()

[Renato Golin via llvm-commits]

rengolin accepted this revision.
rengolin added a comment.
This revision is now accepted and ready to land.

With the two comments, LGTM. Thanks!


================
Comment at: lib/Target/ARM/MCTargetDesc/ARMAsmBackend.cpp:752
@@ +751,3 @@
+    return MachO::CPU_SUBTYPE_ARM_V7;
+
+  case ARM::AK_ARMV4T:
----------------
the king of all nitpicks: too many spaces. :)

================
Comment at: test/CodeGen/ARM/MachO-subtypes.ll:56
@@ +55,3 @@
+
+; RUN: llc -mtriple=xscale-apple-darwin -filetype=obj -o - < %s \
+; RUN: | llvm-readobj -file-headers | FileCheck %s --check-prefix=CHECK-XSCALE
----------------
Do you guys really use xscale? If not, I'd remove it from here.

Support for those deprecated arches is deprecated, and here only for legacy reasons. :)


http://reviews.llvm.org/D11996