[PATCH] D11782: RFC: Target-specific loop idiom recognition

[James Molloy via llvm-commits]

jmolloy added a subscriber: jmolloy.
jmolloy added a comment.

Hi,

I agree with Hal's comment here. I don't see the value-add for other targets from this approach.

What's the value of calling this from LIR? Your hook isn't leveraging off of any of LIR's infrastructure, and that is the usual goal. "Take out what is target independent, and keep what is not" - There's no target independent stuff being hoisted here, you're just running a pass on a loop. You can do that without LIR.

I think you'd have to describe some functionality being shared here before I'll be fully convinced.

Cheers,

James


Repository:
  rL LLVM

http://reviews.llvm.org/D11782