[compiler-rt] r244827 - Move tests that use unistd.h and pthread.h to TestCases/Posix
Alexey Samsonov via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 12 16:32:05 PDT 2015
On Wed, Aug 12, 2015 at 4:25 PM, Reid Kleckner <rnk at google.com> wrote:
> On Wed, Aug 12, 2015 at 4:05 PM, Alexey Samsonov <vonosmas at gmail.com>
>> -// RUN: %clangxx_asan %s %p/Helpers/init-order-pthread-create-extra.cc
>>> -pthread -o %t
>>> +// RUN: %clangxx_asan %s
>>> %p/../Helpers/init-order-pthread-create-extra.cc -pthread -o %t
>> Please move init-order-pthread-create-extra.cc somewhere under
>> TestCases/Posix as well, so that we don't have to go up the directory tree
>> A yet cleaner approach would be to get rid of extra .cc file and create a
>> self-contained test :two sources in one, with a few #ifdef magic - see
>> TestCases/dlclose-test.cc for inspiration.
>> I will totally understand if you refuse to do this extra work :)
> No problem, r244833.
vonosmas at gmail.com
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the llvm-commits