[PATCH] D11982: Use %env_asan_opts= substitution instead of 'env ASAN_OPTIONS=$ASAN_OPTIONS'

Alexey Samsonov via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 12 16:21:12 PDT 2015


samsonov accepted this revision.
samsonov added a comment.
This revision is now accepted and ready to land.

LGTM with an important note.


================
Comment at: test/asan/lit.cfg:38
@@ +37,3 @@
+  default_asan_opts = 'abort_on_error=0'
+config.environment['ASAN_OPTIONS'] = default_asan_opts
+if default_asan_opts:
----------------
Please make sure `ASAN_OPTIONS` environment variable is only set on Darwin. On Linux we still want to test the "default configuration", i.e. when there are no extra env variables set at all.


http://reviews.llvm.org/D11982





More information about the llvm-commits mailing list