[PATCH] D11981: [asan] On OS X, log reports to syslog and os_trace

Anna Zaks via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 12 15:39:39 PDT 2015

zaks.anna added inline comments.

Comment at: lib/asan/asan_report.cc:631
@@ +630,3 @@
+// Removes the ANSI escape sequences from the input string (in-place).
+void RemoveANSIEscapeSequencesFromString(char *str) {
+  if (!str)
kcc wrote:
> OMG, no. 
> Instead of removing the ANSI escapes can't we just not emit them? 
We want the colored report to be printed but store the color-less report in the syslog. The buffer we get here, 'error_message_buffer', is exactly what gets printed. So simply using a different decorator would not work, unless we want to generate the report twice..


More information about the llvm-commits mailing list