[PATCH] D11977: Use modulo semantic to generate non-integer-overflow assumptions

Michael Kruse via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 12 11:28:49 PDT 2015


Meinersbur added inline comments.

================
Comment at: include/polly/Support/SCEVAffinator.h:62
@@ +61,3 @@
+  ///        This context contains all parameter configurations for which we
+  ///        know that the wrapping and non-wrapping expressions are different.
+  ///
----------------
Too many spaces?

================
Comment at: include/polly/Support/SCEVAffinator.h:85
@@ +84,3 @@
+  /// @brief Compute the non-wrapping version of @p PWA for type @p ExprType.
+
+  /// @param PWA  The piece-wise affine function that might wrap.
----------------
Why the empty line 85 between @brief and @param ?

================
Comment at: lib/Support/SCEVAffinator.cpp:115
@@ +114,3 @@
+
+__isl_give isl_pw_aff *SCEVAffinator::addModuloSemantic(isl_pw_aff *PWA,
+                                                        Type *ExprType) {
----------------
__isl_take isl_pw_aff *PWA


http://reviews.llvm.org/D11977





More information about the llvm-commits mailing list