[PATCH] D11982: Use %env_asan_opts= substitution instead of 'env ASAN_OPTIONS=$ASAN_OPTIONS'

[Reid Kleckner via llvm-commits]

rnk created this revision.
rnk added reviewers: samsonov, filcab.
rnk added a subscriber: llvm-commits.

The lit internal shell is used by default on Windows, and it does not support
bash variable expansion. Because bash variable expansion interacts with
tokenization, it is prohibitively difficult to make the existing lit shell do
general shell variable expansion.

The most common use of shell variables in the asan tests is to add options to
the default set of options set by lit.cfg. We can avoid the need for variable
expansion with a substitution that expands to 'env ASAN_OPTIONS=<defaults:>'.

This has the side benefit of shortening the RUN lines, so it seemed better than
implementing limited variable expansion in lit.

http://reviews.llvm.org/D11982

Files:
  test/asan/TestCases/allocator_returns_null.cc
  test/asan/TestCases/asan_and_llvm_coverage_test.cc
  test/asan/TestCases/asan_options-help.cc
  test/asan/TestCases/atexit_stats.cc
  test/asan/TestCases/atoi_strict.c
  test/asan/TestCases/atol_strict.c
  test/asan/TestCases/atoll_strict.c
  test/asan/TestCases/closed-fds.cc
  test/asan/TestCases/contiguous_container_crash.cc
  test/asan/TestCases/coverage-and-lsan.cc
  test/asan/TestCases/coverage-caller-callee-total-count.cc
  test/asan/TestCases/coverage-caller-callee.cc
  test/asan/TestCases/coverage-disabled.cc
  test/asan/TestCases/coverage-levels.cc
  test/asan/TestCases/coverage-maybe-open-file.cc
  test/asan/TestCases/coverage-order-pcs.cc
  test/asan/TestCases/coverage-reset.cc
  test/asan/TestCases/coverage-tracing.cc
  test/asan/TestCases/debug_mapping.cc
  test/asan/TestCases/debug_ppc64_mapping.cc
  test/asan/TestCases/deep_call_stack.cc
  test/asan/TestCases/deep_stack_uaf.cc
  test/asan/TestCases/double-free.cc
  test/asan/TestCases/dump_instruction_bytes.cc
  test/asan/TestCases/gc-test.cc
  test/asan/TestCases/heap-overflow.cc
  test/asan/TestCases/init-order-atexit.cc
  test/asan/TestCases/init-order-pthread-create.cc
  test/asan/TestCases/initialization-blacklist.cc
  test/asan/TestCases/initialization-bug.cc
  test/asan/TestCases/initialization-constexpr.cc
  test/asan/TestCases/initialization-nobug.cc
  test/asan/TestCases/invalid-free.cc
  test/asan/TestCases/log-path_test.cc
  test/asan/TestCases/malloc_context_size.cc
  test/asan/TestCases/malloc_fill.cc
  test/asan/TestCases/max_redzone.cc
  test/asan/TestCases/memcmp_strict_test.cc
  test/asan/TestCases/mmap_limit_mb.cc
  test/asan/TestCases/poison_partial.cc
  test/asan/TestCases/print_summary.cc
  test/asan/TestCases/printf-1.c
  test/asan/TestCases/printf-2.c
  test/asan/TestCases/printf-3.c
  test/asan/TestCases/printf-4.c
  test/asan/TestCases/printf-5.c
  test/asan/TestCases/stack-overflow.cc
  test/asan/TestCases/stack-use-after-return.cc
  test/asan/TestCases/strcasestr-1.c
  test/asan/TestCases/strcasestr-2.c
  test/asan/TestCases/strcasestr_strict.c
  test/asan/TestCases/strcat_strict.c
  test/asan/TestCases/strchr_strict.c
  test/asan/TestCases/strcmp_strict.c
  test/asan/TestCases/strcspn-1.c
  test/asan/TestCases/strcspn-2.c
  test/asan/TestCases/strcspn_strict.c
  test/asan/TestCases/strncat_strict.c
  test/asan/TestCases/strpbrk-1.c
  test/asan/TestCases/strpbrk-2.c
  test/asan/TestCases/strpbrk_strict.c
  test/asan/TestCases/strspn-1.c
  test/asan/TestCases/strspn-2.c
  test/asan/TestCases/strspn_strict.c
  test/asan/TestCases/strstr-1.c
  test/asan/TestCases/strstr-2.c
  test/asan/TestCases/strstr_strict.c
  test/asan/TestCases/strtol_strict.c
  test/asan/TestCases/strtoll_strict.c
  test/asan/TestCases/suppressions-function.cc
  test/asan/TestCases/use-after-poison.cc
  test/asan/TestCases/verbose-log-path_test.cc
  test/asan/lit.cfg
  test/lsan/TestCases/use_after_return.cc

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D11982.31954.patch
Type: text/x-patch
Size: 79355 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150812/c6c12adb/attachment.bin>