[polly] r244606 - Revise the simplification of regions

[Michael Kruse via llvm-commits]

2015-08-12 10:01 GMT+02:00 Johannes Doerfert <doerfert at cs.uni-saarland.de>:
> On 08/12, Michael Kruse wrote:
>> 2015-08-12 9:38 GMT+02:00 Johannes Doerfert <doerfert at cs.uni-saarland.de>:
>> > On 08/12, Michael Kruse via llvm-commits wrote:
>> >> Sich PHI nodes can only appear in the entry
>> >> node. So I think solutions 1 and 3 do work.
>> > What is wrong with adding a pre SCoP block for all entry block PHI
>> > nodes? That solved the problem before and I cannot see the negative side
>> > effects and it needs only a minimal amount of code.
>>
>> Its adding more code to get around issues in other places. Isn't it
>> better to reduce the overall complexity.
> Where does it add complexity or code? It was working before you changed
> the region simplification, hence replicate the old behaviour there
> (which is ~2-3 lines of code) and we are done.

Why add code when we have the chance to remove code to get the same result?

I'd argue fewer lines of code is less complex than more lines of code
(given that fewer lines does replace other code parts)

Michael