[PATCH] D11969: Avoid using of DataLayout::getPointerSize() without address space argument in DWARF info generation

[Stanislav Mekhanoshin via llvm-commits]

rampitec added a comment.

In http://reviews.llvm.org/D11969#222474, @joker.eph wrote:

> I understand that the target defines this field, but it does not say what is the semantic of this field. Where is intended to be used and for what usage?


I agree that is not well defined and I would prefer not to have it. Though I do not see how to support dwarf now without it. If the evil necessary I would personally prefer to have in one place only, removing the calls from TargetMachine and AsmPrinter. Anyhow, what is in the code now clearly does not work for a configuration we have, a MAI implementation does work. So it is bad, but better that nothing.

> The target also controls what TargetMachine::getPointerSize() returns.


That is not really true when a base pointer is used like in this case. The control will never go to target in a way it is done now by dwarf code.


Repository:
  rL LLVM

http://reviews.llvm.org/D11969