[PATCH] D11969: Avoid using of DataLayout::getPointerSize() without address space argument in DWARF info generation

[Mehdi AMINI via llvm-commits]

joker.eph added a comment.

I understand that the target defines this field, but it does not say what is the semantic of this field. Where is intended to be used and for what usage?
The target also controls what TargetMachine::getPointerSize() returns. Admittedly this hook is a transitional one, but the MCAsmInfo does not seem right either to me at this point.

I did a quick archeology and this was introduced in a commit 4 years ago that aknowledged that it does not seem right:

> Move some parts of TargetAsmInfo down to MCAsmInfo. This is not the greatest solution but it is a small step towards removing the horror that is TargetAsmInfo.


I need to bug some expert tomorrow to figure this out.


Repository:
  rL LLVM

http://reviews.llvm.org/D11969