[llvm] r244686 - PseudoSourceValue: Update comments and fix lowercase variable names. NFC.

Alex Lorenz via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 11 15:23:24 PDT 2015


Author: arphaman
Date: Tue Aug 11 17:23:19 2015
New Revision: 244686

URL: http://llvm.org/viewvc/llvm-project?rev=244686&view=rev
Log:
PseudoSourceValue: Update comments and fix lowercase variable names. NFC.

This commit updates the documentation comments in PseudoSourceValue.cpp and
PseudoSourceValue.h based on the LLVM's documentation style. It also fixes
several instances of variable names that started with a lowercase letter.

This change is done in preparation for the changes to the pseudo source value
object management and to the PseudoSourceValue's class hierarchy.

Modified:
    llvm/trunk/include/llvm/CodeGen/PseudoSourceValue.h
    llvm/trunk/lib/CodeGen/PseudoSourceValue.cpp

Modified: llvm/trunk/include/llvm/CodeGen/PseudoSourceValue.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/CodeGen/PseudoSourceValue.h?rev=244686&r1=244685&r2=244686&view=diff
==============================================================================
--- llvm/trunk/include/llvm/CodeGen/PseudoSourceValue.h (original)
+++ llvm/trunk/include/llvm/CodeGen/PseudoSourceValue.h Tue Aug 11 17:23:19 2015
@@ -17,44 +17,42 @@
 #include "llvm/IR/Value.h"
 
 namespace llvm {
+
 class MachineFrameInfo;
 class MachineMemOperand;
 class raw_ostream;
 
 raw_ostream &operator<<(raw_ostream &OS, const MachineMemOperand &MMO);
 
-/// PseudoSourceValue - Special value supplied for machine level alias
-/// analysis. It indicates that a memory access references the functions
-/// stack frame (e.g., a spill slot), below the stack frame (e.g., argument
-/// space), or constant pool.
+/// Special value supplied for machine level alias analysis. It indicates that
+/// a memory access references the functions stack frame (e.g., a spill slot),
+/// below the stack frame (e.g., argument space), or constant pool.
 class PseudoSourceValue {
 private:
   friend class MachineMemOperand; // For printCustom().
 
-  /// printCustom - Implement printing for PseudoSourceValue. This is called
-  /// from Value::print or Value's operator<<.
-  ///
+  /// Implement printing for PseudoSourceValue. This is called from
+  /// Value::print or Value's operator<<.
   virtual void printCustom(raw_ostream &O) const;
 
 public:
-  /// isFixed - Whether this is a FixedStackPseudoSourceValue.
-  bool isFixed;
+  /// Whether this is a FixedStackPseudoSourceValue.
+  bool IsFixed;
 
-  explicit PseudoSourceValue(bool isFixed = false);
+  explicit PseudoSourceValue(bool IsFixed = false);
 
   virtual ~PseudoSourceValue();
 
-  /// isConstant - Test whether the memory pointed to by this
-  /// PseudoSourceValue has a constant value.
-  ///
+  /// Test whether the memory pointed to by this PseudoSourceValue has a
+  /// constant value.
   virtual bool isConstant(const MachineFrameInfo *) const;
 
-  /// isAliased - Test whether the memory pointed to by this
-  /// PseudoSourceValue may also be pointed to by an LLVM IR Value.
+  /// Test whether the memory pointed to by this PseudoSourceValue may also be
+  /// pointed to by an LLVM IR Value.
   virtual bool isAliased(const MachineFrameInfo *) const;
 
-  /// mayAlias - Return true if the memory pointed to by this
-  /// PseudoSourceValue can ever alias an LLVM IR Value.
+  /// Return true if the memory pointed to by this PseudoSourceValue can ever
+  /// alias an LLVM IR Value.
   virtual bool mayAlias(const MachineFrameInfo *) const;
 
   /// A pseudo source value referencing a fixed stack frame entry,
@@ -79,21 +77,17 @@ public:
   static const PseudoSourceValue *getJumpTable();
 };
 
-/// FixedStackPseudoSourceValue - A specialized PseudoSourceValue
-/// for holding FixedStack values, which must include a frame
-/// index.
+/// A specialized PseudoSourceValue for holding FixedStack values, which must
+/// include a frame index.
 class FixedStackPseudoSourceValue : public PseudoSourceValue {
   const int FI;
 
 public:
-  explicit FixedStackPseudoSourceValue(int fi)
-      : PseudoSourceValue(true), FI(fi) {}
+  explicit FixedStackPseudoSourceValue(int FI)
+      : PseudoSourceValue(true), FI(FI) {}
 
-  /// classof - Methods for support type inquiry through isa, cast, and
-  /// dyn_cast:
-  ///
   static inline bool classof(const PseudoSourceValue *V) {
-    return V->isFixed == true;
+    return V->IsFixed == true;
   }
 
   bool isConstant(const MachineFrameInfo *MFI) const override;
@@ -106,6 +100,7 @@ public:
 
   int getFrameIndex() const { return FI; }
 };
-} // End llvm namespace
+
+} // end namespace llvm
 
 #endif

Modified: llvm/trunk/lib/CodeGen/PseudoSourceValue.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/PseudoSourceValue.cpp?rev=244686&r1=244685&r2=244686&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/PseudoSourceValue.cpp (original)
+++ llvm/trunk/lib/CodeGen/PseudoSourceValue.cpp Tue Aug 11 17:23:19 2015
@@ -60,7 +60,7 @@ const PseudoSourceValue *PseudoSourceVal
 static const char *const PSVNames[] = {"Stack", "GOT", "JumpTable",
                                        "ConstantPool"};
 
-PseudoSourceValue::PseudoSourceValue(bool isFixed) : isFixed(isFixed) {}
+PseudoSourceValue::PseudoSourceValue(bool IsFixed) : IsFixed(IsFixed) {}
 
 PseudoSourceValue::~PseudoSourceValue() {}
 




More information about the llvm-commits mailing list