[llvm] r244676 - Fix PR24354.

Hans Wennborg via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 11 14:55:00 PDT 2015


Should we merge this to 3.7? David, what do you think?

On Tue, Aug 11, 2015 at 2:33 PM, Sanjoy Das via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> Author: sanjoy
> Date: Tue Aug 11 16:33:55 2015
> New Revision: 244676
>
> URL: http://llvm.org/viewvc/llvm-project?rev=244676&view=rev
> Log:
> Fix PR24354.
>
> `InstCombiner::OptimizeOverflowCheck` was asserting an
> invariant (operands to binary operations are ordered by decreasing
> complexity) that wasn't really an invariant.  Fix this by instead having
> `InstCombiner::OptimizeOverflowCheck` establish the invariant if it does
> not hold.
>
> Added:
>     llvm/trunk/test/Transforms/InstCombine/pr24354.ll
> Modified:
>     llvm/trunk/lib/Transforms/InstCombine/InstCombineCompares.cpp


More information about the llvm-commits mailing list