[PATCH] Set "thumbv6k" CPU subtype to ARM_V6

Renato Golin via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 11 13:15:29 PDT 2015


On 11 August 2015 at 18:56, Vedant Kumar via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> I think we default to CPU_SUBTYPE_ARM_V7K when we don't know the specific ARM architecture name passed in, which seems sane.

This looks really odd. Then again, this is Darwin specific, so the
rules are different.

I'd be surprised if this is the only case that gets it wrong, and as
fix goes, this is pretty vague.

O Linux we default to ARMv4T for soft-float and ARMv6Z for hard-float.
We also don't have "thumbv*" as we tend to normalise to "armv*" so not
to get that wrong. I'd expect a more thorough fix, and re-using a test
that already exists for that.

cheers,
--renato


More information about the llvm-commits mailing list