[PATCH] D11143: [RFC] Cross Block DSE

[Erik Eckstein via llvm-commits]

eeckstein added inline comments.

================
Comment at: lib/Transforms/Scalar/DeadStoreElimination.cpp:958
@@ +957,3 @@
+          CSI->getModule()->getDataLayout().getTypeStoreSize(MemPtr->getType());
+      AliasResult R = AA->alias(Pointer, PtrSize, MemPtr, MemSize);
+      if (R == MustAlias)
----------------
This is still not correct. You are passing the size of the pointer and not of the referenced memory location.

================
Comment at: lib/Transforms/Scalar/DeadStoreElimination.cpp:1010
@@ +1009,3 @@
+      // A path with backedge may not be safe.Conservatively mark
+      // this store unsafe.
+      if (BackEdgesMap.count(std::make_pair(B, *I)))
----------------
Thanks, I see the problem.


http://reviews.llvm.org/D11143