[llvm] r244621 - Revert "Add non-member begin and end so that drop_begin works on iterator_range."

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 11 09:27:40 PDT 2015


Sorry, it is gcc 4.7 that doesn't like it.

On 11 August 2015 at 12:26, Rafael Espindola via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> Author: rafael
> Date: Tue Aug 11 11:26:06 2015
> New Revision: 244621
>
> URL: http://llvm.org/viewvc/llvm-project?rev=244621&view=rev
> Log:
> Revert "Add non-member begin and end so that drop_begin works on iterator_range."
>
> This reverts commit r244620.
>
> MSVC doesn't like it :-(
>
> Modified:
>     llvm/trunk/include/llvm/ADT/iterator_range.h
>
> Modified: llvm/trunk/include/llvm/ADT/iterator_range.h
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ADT/iterator_range.h?rev=244621&r1=244620&r2=244621&view=diff
> ==============================================================================
> --- llvm/trunk/include/llvm/ADT/iterator_range.h (original)
> +++ llvm/trunk/include/llvm/ADT/iterator_range.h Tue Aug 11 11:26:06 2015
> @@ -47,16 +47,6 @@ public:
>    IteratorT end() const { return end_iterator; }
>  };
>
> -template <typename IteratorT>
> -IteratorT begin(const iterator_range<IteratorT> &R) {
> -  return R.begin();
> -}
> -
> -template <typename IteratorT>
> -IteratorT end(const iterator_range<IteratorT> &R) {
> -  return R.end();
> -}
> -
>  /// \brief Convenience function for iterating over sub-ranges.
>  ///
>  /// This provides a bit of syntactic sugar to make using sub-ranges
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits


More information about the llvm-commits mailing list