[llvm] r231270 - Make DataLayout Non-Optional in the Module

[Mehdi Amini via llvm-commits]

Thanks for the report, should be fixed in r244613.

— 
Mehdi
 
> On Aug 10, 2015, at 12:53 PM, Jonathan Roelofs <jonathan at codesourcery.com> wrote:
> 
> Accidentally sent this to the old list...
> 
> 
> -------- Forwarded Message --------
> Subject: Re: [llvm] r231270 - Make DataLayout Non-Optional in the Module
> Date: Mon, 10 Aug 2015 13:39:57 -0600
> From: Jonathan Roelofs <jonathan at codesourcery.com>
> Organization: CodeSourcery / Mentor Embedded
> To: Mehdi Amini <mehdi.amini at apple.com>, llvm-commits at cs.uiuc.edu
> 
> 
> 
> On 3/4/15 11:43 AM, Mehdi Amini wrote:
>> Author: mehdi_amini
>> Date: Wed Mar  4 12:43:29 2015
>> New Revision: 231270
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=231270&view=rev
>> Log:
>> Make DataLayout Non-Optional in the Module
>> 
> 
> snip
> 
>> 
>> Modified: llvm/trunk/test/Transforms/InstCombine/load-cmp.ll
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/InstCombine/load-cmp.ll?rev=231270&r1=231269&r2=231270&view=diff
>> ==============================================================================
>> --- llvm/trunk/test/Transforms/InstCombine/load-cmp.ll (original)
>> +++ llvm/trunk/test/Transforms/InstCombine/load-cmp.ll Wed Mar  4 12:43:29 2015
> 
> snip
> 
>> @@ -305,11 +232,8 @@ define i1 @test10_struct_arr(i32 %x) {
>>  }
>> 
>>  define i1 @test10_struct_arr_noinbounds(i32 %x) {
>> -; NODL-LABEL: @test10_struct_arr_noinbounds(
>> -; NODL-NEXT  %p = getelementptr [4 x %Foo], [4 x %Foo]* @GStructArr, i32 0, i32 %x, i32 2
>> -
>> -; P32-LABEL: @test10_struct_arr_noinbounds(
>> -; P32-NEXT  %p = getelementptr [4 x %Foo], [4 x %Foo]* @GStructArr, i32 0, i32 %x, i32 2
>> +; CHECK-LABEL: @test10_struct_arr_noinbounds(
>> +; CHECK-NEXT  %p = getelementptr [4 x %Foo], [4 x %Foo]* @GStructArr, i32 0, i32 %x, i32 2
> 
> Mehdi,
> 
> This CHECK-NEXT is missing its ':'.  I tried adding it, but the
> currently emitted code no longer matches this check.  Can you please
> take a look?
> 
> 
> Thanks,
> 
> Jon
> 
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>> 
> 
> -- 
> Jon Roelofs
> jonathan at codesourcery.com
> CodeSourcery / Mentor Embedded
> 
>