[PATCH] D11143: [RFC] Cross Block DSE

Karthik Bhat via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 11 04:00:17 PDT 2015


karthikthecool updated this revision to Diff 31785.
karthikthecool added a comment.

Run clang-format on updated patch and implement Hal's review comments.
I agree with Hal that we may hoist dyn_cast<StoreInst> above ModRef check. In case of store we can rely on Alias Analysis's alias to check if the stores mustalias. For other cases we can use getModRefInfo to make make sure that this instruction which is not a store does not Mod/Ref the pointer. Updated and tested the code after modification.
Please let me know your inputs on the same.

Thanks once again to all reviewers for spending their valuable time on this patch.
Regards
Karthik Bhat


http://reviews.llvm.org/D11143

Files:
  lib/Transforms/Scalar/DeadStoreElimination.cpp
  test/Transforms/DeadStoreElimination/cross_block_dse.ll
  test/Transforms/DeadStoreElimination/cross_block_dse_loop.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D11143.31785.patch
Type: text/x-patch
Size: 19262 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150811/5dc588eb/attachment.bin>


More information about the llvm-commits mailing list