[PATCH] D10923: [mips][microMIPS] Create microMIPS64r6 subtarget and implement DALIGN, DAUI, DAHI, DATI, DEXT, DEXTM and DEXTU instructions

[Daniel Sanders via llvm-commits]

dsanders accepted this revision.
dsanders added a comment.
This revision is now accepted and ready to land.

LGTM with the '-*- tablegen -*-' issue fixed.


================
Comment at: lib/Target/Mips/MicroMips64r6InstrFormats.td:1-2
@@ +1,3 @@
+//=-      MicroMips64r6InstrFormats.td - Mips64r6 Instruction Formats       -=//
+//                             -*- tablegen -*
+//
----------------
Unfortunately, this bit needs to be on the first line. It tells emacs (and presumably other editors) what the file format is.

I'd drop the redundant 'Mips64r6' in 'Mips64r6 Instruction Formats'.

================
Comment at: lib/Target/Mips/MicroMips64r6InstrInfo.td:2
@@ +1,3 @@
+//=-    MicroMips64r6InstrInfo.td - MicroMips64r6 Instruction Information   -=//
+//                               -*- tablegen -*-
+//
----------------
Likewise


http://reviews.llvm.org/D10923