[PATCH] D11852: [LowerSwitch] Fix a bug when LowerSwitch deletes the default block

Chen Li via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 10 21:08:21 PDT 2015


chenli added a comment.

In http://reviews.llvm.org/D11852#221321, @reames wrote:

> The revised patch is strictly less powerful than the current code and the previous patch.  If a block occurs earlier in the iteration order than the only block which reaches it and we then delete the reaching edge, we will now fail to remove the unreachable block.  I would prefer the first patch posted over the revised one.


Yes, you are correct. I didn't think about this case. I will submit the initial patch if Hans is ok with that.


http://reviews.llvm.org/D11852





More information about the llvm-commits mailing list