[PATCH] D11791: [Windows] Use llvm-symbolizer before using dbghelp

[Reid Kleckner via llvm-commits]

rnk marked 4 inline comments as done.

================
Comment at: lib/sanitizer_common/sanitizer_common.cc:347
@@ -346,1 +346,3 @@
 
+char *FindPathToBinary(const char *name) {
+  const char *path = GetEnv("PATH");
----------------
samsonov wrote:
> Move this function in a separate change.
D11920

================
Comment at: lib/sanitizer_common/sanitizer_symbolizer_win.cc:242
@@ +241,3 @@
+
+  // Add llvm-symbolizer in case the binary has dwarf.
+  const char *user_path = common_flags()->external_symbolizer_path;
----------------
samsonov wrote:
> Does Windows properly handle `common_flags()->symbolize`?  We shouldn't create any symbolizers if this flag is true.
Apparently not. I added that here.

================
Comment at: test/asan/CMakeLists.txt:19
@@ +18,3 @@
+  list(APPEND ASAN_TEST_DEPS asan)
+  if(WIN32 AND EXISTS ${CMAKE_SOURCE_DIR}/tools/lld)
+    list(APPEND CFI_TEST_DEPS
----------------
samsonov wrote:
> Let's introduce `COMPILER_RT_HAS_LLD_SOURCES` in the same way we use `COMPILER_RT_HAS_LIBCXX_SOURCES`, and use a common variable to check if lld is available somewhere in `test/lit.common.configured.in` instead of `ASAN_HAS_LLD`
OK

================
Comment at: test/asan/TestCases/Windows/operator_new_left_oob.cc:14
@@ -13,3 +13,3 @@
 // CHECK: allocated by thread T0 here:
-// CHECK:   {{#0 .* operator new }}
+// CHECK:   {{#0 .* operator new}}
 // CHECK:   {{#1 .* main .*operator_new_left_oob.cc}}:[[@LINE-8]]
----------------
samsonov wrote:
> Please relax all these test cases in a separate change.
rL244522


http://reviews.llvm.org/D11791