[PATCH] D11914: WebAssembly: print immediates

JF Bastien via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 10 15:38:12 PDT 2015


jfb added inline comments.

================
Comment at: lib/Target/WebAssembly/WebAssemblyAsmPrinter.cpp:122
@@ +121,3 @@
+          buf, /*hexDigits=*/0, /*upperCase=*/false,
+          APFloat::rmNearestTiesToEven);
+      assert(Written != 0);
----------------
sunfish wrote:
> It looks like APFloat's NaN printing doesn't include the significand (the "(n-char-sequence)"). I don't want to bikeshed on the format here, but we'll need to do *something* to preserve all the information in any case. Can you add asserts, or perhaps just highly-visible comments, indicating that we're missing functionality here?
I changed it to canonicalize by default. The code looks a bit weird, so that all the bits are in place to do something else if we want to.


Repository:
  rL LLVM

http://reviews.llvm.org/D11914





More information about the llvm-commits mailing list