[PATCH] D11316: [X86] -- Fix fptoui i64 conversions for IA32 (performance and correctness)

[David Majnemer via llvm-commits]

majnemer added inline comments.

================
Comment at: lib/Target/X86/X86ISelLowering.cpp:12399
@@ +12398,3 @@
+      Low32 = DAG.getNode(ISD::ZERO_EXTEND, DL, MVT::i64, Low32);
+      High32 = DAG.getNode(ISD::ZERO_EXTEND, DL, MVT::i64, High32);
+      High32 = DAG.getNode(ISD::SHL, DL, MVT::i64, High32,
----------------
Could we use `ANY_EXTEND` for `High32`? We will shift out the top 32-bits anyway.

================
Comment at: lib/Target/X86/X86ISelLowering.cpp:12696
@@ -12604,1 +12695,3 @@
+  // If FP_TO_INTHelper failed, the node is actually supposed to be Legal.
+  if (!FIST.getNode()) return Op;
 
----------------
Please format the return onto its own line.


http://reviews.llvm.org/D11316