[PATCH] D11901: [TTI] Add a hook for specifying per-target defaults for Interleaved Accesses

Renato Golin via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 10 06:10:06 PDT 2015


rengolin added inline comments.

================
Comment at: lib/Transforms/Vectorize/LoopVectorize.cpp:3886
@@ +3885,3 @@
+  // If an override option has been passed in for interleaved accesses, use it.
+  if (EnableInterleavedMemAccesses.getNumOccurrences() > 0)
+    UseInterleaved = EnableInterleavedMemAccesses;
----------------
sbaranga wrote:
> rengolin wrote:
> > Why the use of getNumOccurrences?
> We want to use EnableInterleavedMemAccess only when the user has specified this option on the command line, otherwise we want to use the target defaults.
> 
> As far as I can tell, we need to use getNumOccurences to do that.
But EnableInterleavedMemAccess is a boolean, so just using it as before should work, no?

    if (EnableInterleavedMemAccesses ||
        TTI->enableInterleavedAccessVectorization())
      InterleaveInfo.analyzeInterleaving(Strides);


http://reviews.llvm.org/D11901





More information about the llvm-commits mailing list