[PATCH] D11894: [libunwind] Remove unused includes

whitequark via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 10 01:07:11 PDT 2015


whitequark created this revision.
whitequark added reviewers: kledzik, rengolin.
whitequark added a subscriber: llvm-commits.

These include directives seem to be carried over from libc++abi. Nothing defined in them seems to be used and they do not break build of libunwind on any compiler/platform I tried. (Unlike `#include <algorithm>`, which is apparently necessary for static_assert on gcc.)

http://reviews.llvm.org/D11894

Files:
  src/DwarfParser.hpp
  src/Registers.hpp
  src/libunwind.cpp

Index: src/libunwind.cpp
===================================================================
--- src/libunwind.cpp
+++ src/libunwind.cpp
@@ -16,9 +16,6 @@
 #include <cstdlib> // getenv
 #endif
 #include <new>
-#include <tuple>
-#include <memory>
-#include <vector>
 #include <algorithm>
 
 #include "libunwind_ext.h"
Index: src/Registers.hpp
===================================================================
--- src/Registers.hpp
+++ src/Registers.hpp
@@ -14,7 +14,6 @@
 #define __REGISTERS_HPP__
 
 #include <stdint.h>
-#include <strings.h>
 #include <string.h>
 
 #include "libunwind.h"
Index: src/DwarfParser.hpp
===================================================================
--- src/DwarfParser.hpp
+++ src/DwarfParser.hpp
@@ -18,8 +18,6 @@
 #include <stdio.h>
 #include <stdlib.h>
 
-#include <vector>
-
 #include "libunwind.h"
 #include "dwarf2.h"
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D11894.31637.patch
Type: text/x-patch
Size: 863 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150810/ab9853e7/attachment.bin>


More information about the llvm-commits mailing list