[PATCH] D11566: Fix FlattenCFG to invert test when different index is encountered, and add one more operator to invert.

hfinkel@anl.gov via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 10 00:41:58 PDT 2015

hfinkel added a subscriber: hfinkel.

Comment at: lib/Transforms/Utils/FlattenCFG.cpp:202
@@ -201,3 +201,3 @@
       Idx = CIdx;
-    else if (CIdx != Idx)
-      return false;
+    else if (CIdx != Idx) {
+      bool EverChanged = false;
I think that I'm missing something here: We currently might perform this change when CIdx == Idx, and with this patch, we only ever do it when CIdx != Idx. Don't you want to do it in both cases?


More information about the llvm-commits mailing list