[PATCH] D11146: [ValueTracking] Add support for floating-point minnum and maxnum

[hfinkel@anl.gov via llvm-commits]

hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.

LGTM.


================
Comment at: lib/Analysis/ValueTracking.cpp:3377
@@ +3376,3 @@
+      if (LHSSafe)
+        // LHS is non-NaN, so RHS is NaN.
+        NaNBehavior = SPNB_RETURNS_NAN;
----------------
"so RHS is NaN" is a bit too much short-hand I think. We don't know that the RHS is NaN, we know that if it is NaN, then it will be returned. Please make the comment a bit more specific.



Repository:
  rL LLVM

http://reviews.llvm.org/D11146