[PATCH] D11875: [RegionInfo] Add debug-time region viewer functions

[Tobias Grosser via llvm-commits]

grosser accepted this revision.
grosser added a comment.
This revision is now accepted and ready to land.

LGTM. Thanks for this nice debugging functionality.


================
Comment at: include/llvm/Analysis/RegionInfo.h:856
@@ +855,3 @@
+
+  /// @brief Opens a viewer to show the GraphViz vizualization of this region
+  /// without instructions in the BasicBlocks.
----------------
visualization

================
Comment at: include/llvm/Analysis/RegionPrinter.h:44
@@ +43,3 @@
+  /// manager currently holds.
+  ///
+  /// @param F Function to analyze.
----------------
Maybe mention in the comments here that a new analysis is run (you mention this implicitly, but being explicit about this would be good).

================
Comment at: include/llvm/Analysis/RegionPrinter.h:61
@@ +60,3 @@
+  /// Shows only the BasicBlock names without their instructions.
+  /// The result of a new analysis may differ from the RegionInfo the pass
+  /// manager currently holds.
----------------
Please be explicit about it running a new analysis.


Repository:
  rL LLVM

http://reviews.llvm.org/D11875