[PATCH] D11866: transform fmin/fmax calls when possible (PR24314)

[James Molloy via llvm-commits]

jmolloy added a comment.

Hi Sanjay,

Generally this looks fine, but you should be adding the nnan and nsz attributes to the fcmp instruction via the IRBuilder for value tracking to pick up the relaxedness.

This will be important when my latest patches finally land and x86 uses the new ISD::FMINNAN nodes (which represent the semantics of minss precisely).

Cheers,

James


http://reviews.llvm.org/D11866