[PATCH] D11876: [Support] Always wait for GraphViz before opening the viewer

[Michael Kruse via llvm-commits]

Meinersbur created this revision.
Meinersbur added reviewers: Bigcheese, chandlerc.
Meinersbur added a subscriber: llvm-commits.
Meinersbur set the repository for this revision to rL LLVM.

When calling DisplayGraph and a PS viewer is chosen, two programs are executed: The GraphViz generator and the PostScript viewer. Always for the generator to finish to ensure that the .ps file is written before opening the viewer for that file. DisplayGraph's wait parameter refers to whether to wait until the user closes the viewer.

At least on Windows otherwise it may happen that the viewer tries to open a file that doesn't exist yet.

Repository:
  rL LLVM

http://reviews.llvm.org/D11876

Files:
  lib/Support/GraphWriter.cpp

Index: lib/Support/GraphWriter.cpp
===================================================================
--- lib/Support/GraphWriter.cpp
+++ lib/Support/GraphWriter.cpp
@@ -219,7 +219,7 @@
 
     errs() << "Running '" << GeneratorPath << "' program... ";
 
-    if (ExecGraphViewer(GeneratorPath, args, Filename, wait, ErrMsg))
+    if (ExecGraphViewer(GeneratorPath, args, Filename, true, ErrMsg))
       return true;
 
     args.clear();


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D11876.31597.patch
Type: text/x-patch
Size: 438 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150808/d597b6e6/attachment.bin>