[PATCH] D11714: AMDGPU/SI: Remove VCCReg

[Tom Stellard via llvm-commits]

tstellarAMD added inline comments.

================
Comment at: lib/Target/AMDGPU/SIInstrInfo.td:1128-1130
@@ +1127,5 @@
+// an explicit $dst.
+class VOPC_Profile<ValueType vt> : VOPProfile <[i1, vt, vt, untyped]> {
+  let Asm32 = "vcc, $src0, $src1";
+}
+
----------------
Can you change this to something like:

class VOPC_Profile<ValueType vt0, ValueType vt1 = vt0> : ...

So that the VOP_I1_* class can inherit from this and don't need to duplicate the Asm32 string.

================
Comment at: lib/Target/AMDGPU/SIInstrInfo.td:1137
@@ -1125,1 +1136,3 @@
+
 def VOP_I1_F32_I32 : VOPProfile <[i1, f32, i32, untyped]> {
+  let Asm32 = "vcc, $src0, $src1";
----------------
Can you rename this class to VOPC_I1_F32_I32 for consistency.

================
Comment at: lib/Target/AMDGPU/SIInstrInfo.td:1144
@@ -1129,2 +1143,3 @@
 
 def VOP_I1_F64_I32 : VOPProfile <[i1, f64, i32, untyped]> {
+  let Asm32 = "vcc, $src0, $src1";
----------------
Same here, use VOPC prefix.


http://reviews.llvm.org/D11714