[llvm] r244303 - ELF: Add AMDGPU specific defintions

[Davide Italiano via llvm-commits]

On Thu, Aug 6, 2015 at 7:05 PM, Davide Italiano <davide at freebsd.org> wrote:
> On Thu, Aug 6, 2015 at 6:35 PM, Tom Stellard via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
>> Author: tstellar
>> Date: Thu Aug  6 20:35:24 2015
>> New Revision: 244303
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=244303&view=rev
>> Log:
>> ELF: Add AMDGPU specific defintions
>>
>
> Hi Tom,
>
>> Reviewers: rafael
>>
>> Subscribers: llvm-commits
>>
>
>> -  W.printEnum  ("Type", Symbol->getType(), makeArrayRef(ElfSymbolTypes));
>> +  if (Obj->getHeader()->e_machine == ELF::EM_AMDGPU &&
>> +      SymbolType >= ELF::STT_LOOS && SymbolType < ELF::STT_HIOS)
>
> I think the second check can be spelled as sym->isOSSpecific().
>

Hmm, after a closer look I'm not sure this is true. Better leaving it
as is, nevermind.


-- 
Davide

"There are no solved problems; there are only problems that are more
or less solved" -- Henri Poincare