[PATCH][MC/Dwarf] Allow to specify custom parameters for linetable emission.

[Frédéric Riss via llvm-commits]

> On Aug 6, 2015, at 3:54 PM, David Blaikie <dblaikie at gmail.com> wrote:
> 
> 
> 
> On Thu, Aug 6, 2015 at 3:50 PM, Frédéric Riss <friss at apple.com <mailto:friss at apple.com>> wrote:
> 
>> On Aug 6, 2015, at 3:21 PM, David Blaikie <dblaikie at gmail.com <mailto:dblaikie at gmail.com>> wrote:
>> 
>> No need for "LTParams(), " in the MCAssembler ctor, is there?
> 
> 'course not.
> 
>> Is the '+' needed here "+Params.DWARF2LineOpcodeBase - 1” ?
> 
> :-) I must have copied over a failed hunk from a .rej file and then clang-format-diff stuck it to the expression.
> 
>> There's some unrelated formatting changes (forceExpAbs?) that could be removed.
>> 
>> & I guess this has been run through clang-format?
> 
> Hence the formatting changes. 
> 
> There's a handy script that just clang-formats things that have already been touched ("tools/clang/tools/clang-format/git-clang-format origin" is how I use it, then inspect the local changes & commit them if they look reasonable).

Mmmh, I’ll try that. I currently use "git diff | tools/clang/tools/clang-format/clang-format-diff.py -i -p1”. I would have expected that to be equivalent.

> New patch attached.
> 
> Looks good - please commit :)

Thanks!
> 
> - Dave
>  
> 
> 
> 
>> On Thu, Aug 6, 2015 at 3:11 PM, Frédéric Riss <llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>> wrote:
>> Hi,
>> 
>> The attached patch (based on a patch from Adrian), allows to customize the encoding of the Dwarf line tables emitted by MC. llvm-dsymutil has be able to recreate line tables that were created by other compilers and that do not necessarily use the same settings. The patch is really mechanical just threading a new word-sized MCDwarfLineTableParams trust through he linetable routines. The patch is NFC wrt current uses.
>> 
>> 
>> 
>> 
>> Fred 
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits <http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150806/5842f55a/attachment.html>